Run isort as pre-commit hook #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run it before flake8, so any errors will get fixed automatically. Fixes cookiecutter#2711
Add myself, and fix link to @sorasful
We could, yes. Don't see a problem to keep it around, but maybe it is?
I think it's best to keep it around for now.
It's installing each hook in a separate virtualenv. |
browniebroke
approved these changes
Aug 11, 2020
|
Going to merge this, it's a good improvement. Feel free to send another one if you see some issues with having |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run it before flake8, so any errors will get fixed automatically.
Fixes #2711
Should we also remove flake8-isort from the flake8 check? And remove the flake8-isort requirement?
It's not clear to me yet whether pre-commit runs and installs its hooks in the same environment you are using, or in a separate virtualenv, so I don't know if it is an issue someone already has an older isort installed.